Default value must be manually handled

[cstamas]

Default must be manually handled, i missed this.

Fixes #912

[wendigo]

That works :) Thanks!

[cstamas]

Am adding IT (something I'd done initially would catch this), and will merge

[cstamas]

The code change is OK and fixes issue, but something else is wrong.
Created #957

The maven.config is ignored by mvnd, hence it tries (local repo shows the attempt) to load extension foo:bar but naturally fails, but continues instead to fail the build.

[wendigo]

Can we get this in for alpha14?

[cstamas]

Sure, this will be in it. But as i wrote, seems there is something else to be fixed as IT this PR adds shows...

[cstamas]

@gnodet If you run this PR locally:

• it will pass ok, but
• maven-conf-ignore-ext IT is wrong: maven.conf where ignore is, is not observed by mvnd. Also local repository will show that extension foo:bar is attempted to resolve, but naturally unsuccessfully
• this means that mvnd happily goes along instead to fail (as it failed to resolve the extension)

Any idea?

[gnodet]

@gnodet If you run this PR locally:

• it will pass ok, but
• maven-conf-ignore-ext IT is wrong: maven.conf where ignore is, is not observed by mvnd. Also local repository will show that extension foo:bar is attempted to resolve, but naturally unsuccessfully
• this means that mvnd happily goes along instead to fail (as it failed to resolve the extension)

Any idea?

Yes, the problem is here:

• maven-mvnd/daemon-m40/src/main/java/org/apache/maven/cli/DaemonMavenCli.java

  Line 699 in dc4179f

  slf4jLogger.warn("Failed to load extensions descriptor {}: {}", extensions, e.getMessage());

• maven-mvnd/daemon-m39/src/main/java/org/apache/maven/cli/DaemonMavenCli.java

  Line 615 in dc4179f

  slf4jLogger.warn("Failed to load extensions descriptor {}: {}", extensions, e.getMessage());

  
  A failure to resolve the extension simply prints a warning and ignore.... That should be fixed.

[gnodet]

I think this should be:

String exclusionsString =
                systemProperty(Environment.MVND_CORE_EXTENSIONS_EXCLUDE).orDefault().asString();

[gnodet]

This should definitely not be part of the output, and not 4 times.
I'll revert this chunk, or log to debug at most.

[cstamas]

Unsure why ubuntu failed, win passed.... locally also passed w/ same CLI params as CI invoked 🤔

[gnodet]

I don't think this one is discriminating. What is discriminating is the list of extensions to load which may actually be affected by this property, but not necessarily. If you add an exclusion which is not supposed to be loaded, this won't affect the result. In addition, that property is not really interesting on the daemon side, as the extensions list is loaded by the client...

[cstamas]

removed