Align mvnd m39 with Maven 3.9.x re config interpolation #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Port Maven 3.9.7 config and new properties (session.root/top) into Daemon m39. The IT got this property as it triggers exception (failure) if mvn39 could not "discover" top directory. Fixes apache#910
|
@wendigo ping |
gnodet
approved these changes
Apr 19, 2024
|
@wendigo Would be grateful if you build mvnd locally and try it with Trino build, it should now work OOTB. No need for native and all that, just |
|
Will do @cstamas |
|
@cstamas unfortunately still doesn't work for our case. I've tried reapplying: trinodb/trino@ff1cddb and that works in mvn but not in mvnd |
|
Adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port Maven 3.9.6 config and new properties (session.root/top) interpolation into Daemon m39.
The IT got this property as it triggers exception (failure) if mvn39 could not "discover" top directory.
Fixes #910