Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build instructions for Windows #890

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

KasNotten
Copy link
Contributor

@KasNotten KasNotten commented Oct 14, 2023

I would like to propose adding the following details to the instructions for building maven-mvnd on Windows.
I had to spend some time figuring out which tools I needed and I figured I would save other future Windows contributors the trouble.

@mthmulders mthmulders changed the title Update build instructions for windows Update build instructions for Windows Oct 15, 2023
@mthmulders
Copy link

It confuses me that the build fails, but only on Ubuntu, for something that's only a documentation change. @gnodet / @ppalaga, any objections on merging it, despite the failing build?

@gnodet
Copy link
Contributor

gnodet commented Oct 16, 2023

It confuses me that the build fails, but only on Ubuntu, for something that's only a documentation change. @gnodet / @ppalaga, any objections on merging it, despite the failing build?

Some tests are flaky. When that's the case, I usually re-run them to have green lights...

@gnodet gnodet merged commit 09168b3 into apache:master Oct 16, 2023
4 checks passed
@gnodet gnodet added this to the 1.0-m8 milestone Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants