Random minor fixes / clean-up in OsUtils #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* the String.join() is more readable and there should not be any downsides (like performance or so)
* fix typo in method names * add a test for the other *toHumanReadable method * replace StringBuilder usage with simple concatenation where applicable (for fixed length strings)
psiroky
changed the title
gnodet
approved these changes
Mar 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When browsing through the code I encountered some small things which I think makes sense to fix, so I figured I would create a PR.
I may possibly create more of these if I encounter similar things elsewhere in the code -- and of course if PRs likes are something you are interested in (as I know reviewing things like this is not super exciting)