Add more discriminating properties to the daemon #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oehme
force-pushed
the
oehme/local-repo-discriminates
branch
3 times, most recently
from
2bf0a43 to
8de024e
Compare
The local repo and maven settings are both used while resolving core extensions, which happens during daemon startup. Thus these two also need to be discriminating properties, as the core extensions themselves are discriminating.
oehme
force-pushed
the
oehme/local-repo-discriminates
branch
from
8de024e to
9b9221d
Compare
|
Indeed, very useful, thanks @oehme! |
marcphilipp
reviewed
Dec 9, 2022
| OptionType.PATH, | ||
| Flags.DISCRIMINATING | Flags.OPTIONAL, | ||
| "mvn:-s", | ||
| "mvn:--settings"), |
There was a problem hiding this comment.
@oehme Should this also apply to -gs and --global-settings?
There was a problem hiding this comment.
Yes, it should, but from a cursory look at this class it's not yet supported at all. I also think that the Java Home should be discriminating and that the actual content of the settings.xml should be considered as well, but all of these seemed out of scope for this PR.
gnodet
added a commit
to gnodet/mvnd
that referenced
this pull request
Dec 9, 2022
gnodet
added a commit
that referenced
this pull request
Dec 9, 2022
gnodet
added a commit
that referenced
this pull request
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The local repo and maven settings are both used while resolving core extensions, which happens during daemon startup. Thus these two also need to be discriminating properties, as the core extensions themselves are discriminating.
Our concrete use case is that our extension's integration tests use an isolated repository which is deleted after the build, so we don't pile up garbage data on our CI agents. The lack of support for a custom local repository means we currently can't run the tests for our Maven extension against the Maven daemon.