Fixup #716 Calculate java home from java command #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a test * Simplify the stream processing
gnodet
approved these changes
Oct 18, 2022
gzm55
reviewed
Oct 18, 2022
| private String javaHomeFromPath() { | ||
| final String jHome = OsUtils.findJavaHomeFromPath(); | ||
| private static String javaHomeFromPath() { | ||
| LOG.warn("Falling back to finding JAVA_HOME by running java executable available in PATH." |
There was a problem hiding this comment.
why warn here? the generic java version (mvnd.sh) will also search java from path without a warning
There was a problem hiding this comment.
why warn here? the generic java version (mvnd.sh) will also search java from path without a warning
As long as I am on an OS and arch having a mvnd native executable, I do not need to care that mvnd.sh is slow. mvnd.sh is fallback where some expectations are not met. But actually we could warn in mvnd.sh too. I'd prefer knowing that mvnd is missing some piece of config that makes it slower.
# Conflicts: # client/src/main/java/org/mvndaemon/mvnd/client/DaemonParameters.java # common/src/main/java/org/mvndaemon/mvnd/common/OsUtils.java # common/src/test/java/org/mvndaemon/mvnd/common/OsUtilsTest.java
gnodet
added a commit
that referenced
this pull request
Jan 6, 2023
* Add a test * Simplify the stream processing Co-authored-by: Guillaume Nodet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixup #715