Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement build cancelation #199

Merged
merged 1 commit into from
Nov 10, 2020
Merged

Implement build cancelation #199

merged 1 commit into from
Nov 10, 2020

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented Nov 10, 2020

fixes #127

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 10, 2020

This is a bit different than the original #195 : the cancellation request is not enforced while the DaemonConnector is connecting. It is rather stored in a temporary outbound queue, waiting for the connection and is send to the daemon only after when the connection is established. Could you please review @gnodet ?

@gnodet
Copy link
Contributor

gnodet commented Nov 10, 2020

I'd like to keep the ability to cancel the client during the first few seconds while it's trying to connect to a daemon.
I think it currently somewhat works because of #193, so I think the daemon is killed very early when hitting Ctrl+C.

Also, it seems the client is waiting for the daemon to process the cancellation request cleanly. I don't think this is a desirable behaviour. It can slow the response on the client side a few seconds. The client should send the cancel message and exit early.

@gnodet
Copy link
Contributor

gnodet commented Nov 10, 2020

I'd like to keep the ability to cancel the client during the first few seconds while it's trying to connect to a daemon.
I think it currently somewhat works because of #193, so I think the daemon is killed very early when hitting Ctrl+C.

Also, it seems the client is waiting for the daemon to process the cancellation request cleanly. I don't think this is a desirable behaviour. It can slow the response on the client side a few seconds. The client should send the cancel message and exit early.

I should have a proposal in a few minutes...

@gnodet
Copy link
Contributor

gnodet commented Nov 10, 2020

@ppalaga see gnodet@3a38265

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 10, 2020

Thanks, amended with minor changes in c52dfa3

@ppalaga ppalaga merged commit 0800aeb into apache:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement build cancellation
2 participants