Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvnd IT: increase connectTimeout for ITs #1171

Merged
merged 5 commits into from
Oct 17, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Oct 17, 2024

Experiment PR to figure out why MacOS GH runners keep failing with transport related (SSL handshake abort, HTTP timeouts) errors. As we know linux and windows boxes are in Azure, while macos boxes are somewhere else, and we get regularly real strange errors like "SSL handshake errors", "HTTP timeout error (against Central?)", so suspicion is on JDK transport (in HTTP/2 mode).

Experiments:

  • force apache transport (HTTP/1.1) - ✔️
  • force JDK transport into HTTP/1.1 - 🟥
  • use big timeout for connectTimeout - ✔️

Conclusion: apache transport ignores "request timeout" seemingly, so it performs "more robust", while JDK transport strictly enforces timeouts, and it seems GH macOS runners are having way slower networking. For ITs we will for now increase the default (10sec) connectTimeout Resolver configuration, as it seems too low.

Just a desperate PR to figure out why MacOS GH runners keep
failing with transport related (SSL handshake abort, HTTP timeouts)
errors.
@cstamas cstamas added the not for merge DO NOT merge (experiment) label Oct 17, 2024
@cstamas cstamas requested a review from gnodet October 17, 2024 08:02
@cstamas cstamas self-assigned this Oct 17, 2024
@cstamas cstamas changed the title Force apache transport Experimenting with transports: ITs are unstable on macOS boxes Oct 17, 2024
Circumvent low connectTimeouts and GH macOS runners when
JDK transport is used (default).
@cstamas cstamas removed the not for merge DO NOT merge (experiment) label Oct 17, 2024
@cstamas cstamas changed the title Experimenting with transports: ITs are unstable on macOS boxes mvnd IT: increase connectTimeout for ITs Oct 17, 2024
@cstamas cstamas marked this pull request as ready for review October 17, 2024 12:06
@cstamas cstamas merged commit 11a6ed3 into apache:master Oct 17, 2024
5 checks passed
@cstamas cstamas deleted the force-apache-transport branch October 17, 2024 12:07
@cstamas cstamas added this to the 2.0.0-beta-2 milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant