Remove outdated note about oh-my-zsh #1034
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first-time user of the Maven Daemon, I was reading the README to make sure I apply everything that is relevant in my context.
I was curious about the note to the
oh-my-zsh
users, about a previous incompatibility betweenmvnd
and the alias of themvn deploy
used by theomz
maven plugin.On a second look, it seems that the incompatibility has been resolved because
oh-my-zsh
has renamedmvnd
tomvndp
to resolve this particular problem.Please check the relevant commit: ohmyzsh/ohmyzsh#11756
and the linked issue: ohmyzsh/ohmyzsh#11713
The up-to-date
omz maven plugin
documentation reflects the change: https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/mvnmvndp
mvn deploy
Since this incompatibility seems to be no longer possible, I would suggest to drop this section from the documentation.
P.S. My PR does not link to an issue since I just considered it a simple cleanup. Should I create one?