Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated note about oh-my-zsh #1034

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

albihasani94
Copy link
Contributor

@albihasani94 albihasani94 commented Jun 18, 2024

As a first-time user of the Maven Daemon, I was reading the README to make sure I apply everything that is relevant in my context.

I was curious about the note to the oh-my-zsh users, about a previous incompatibility between mvnd and the alias of the mvn deploy used by the omz maven plugin.

On a second look, it seems that the incompatibility has been resolved because oh-my-zsh has renamed mvnd to mvndp to resolve this particular problem.

Please check the relevant commit: ohmyzsh/ohmyzsh#11756
and the linked issue: ohmyzsh/ohmyzsh#11713

The up-to-date omz maven plugin documentation reflects the change: https://github.com/ohmyzsh/ohmyzsh/tree/master/plugins/mvn

Alias Command
mvndp mvn deploy

Since this incompatibility seems to be no longer possible, I would suggest to drop this section from the documentation.

P.S. My PR does not link to an issue since I just considered it a simple cleanup. Should I create one?

@gnodet gnodet merged commit d2942cc into apache:master Jun 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants