Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More script changes #1020

Merged
merged 3 commits into from
Jun 14, 2024
Merged

More script changes #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6c86dc9
More script changes
cstamas Jun 14, 2024
8f731d2
Just add whenever mvn would resolve deps the settings as well
cstamas Jun 14, 2024
8a8dd08
Add reminder message
cstamas Jun 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: 'Build source distribution'
run: ./mvnw clean verify -Psource-distribution -N -B -ntp -e
run: ./mvnw clean verify -Psource-distribution -N -B -ntp -e -s .mvn/release-settings.xml

- name: 'Upload artifact'
uses: actions/upload-artifact@v4
Expand Down
12 changes: 9 additions & 3 deletions build/release-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ startup_check
# update version
mvn versions:set -DnewVersion=$VERSION

# udpate changelog
# update changelog
docker run -it --rm -v "$(pwd)":/usr/local/src/your-app githubchangeloggenerator/github-changelog-generator \
--user apache --project maven-mvnd --token $GITHUB_TOKEN --future-release $VERSION \
--exclude-tags early-access,0.9.0,1.0.0-m2,build-1.0.0-m2,1.0.0-m3
Expand All @@ -129,7 +129,7 @@ git commit -m "[release] Release $VERSION"

# Create and push tag
git tag $VERSION
git push origin $VERSION
# git push origin $VERSION
# Pushing a tag will trigger the CI to build the release and publish
# the artifacts on https://github.com/apache/maven-mvnd/releases

Expand All @@ -139,4 +139,10 @@ mvn versions:set -DnewVersion=$NEXT_VERSION
# commit
git add -A
git commit -m "Next is $NEXT_VERSION"
git push origin mvnd-1.x
# git push origin mvnd-1.x

# NOTE: Manually push once done: git push origin mvnd-1.x --tags
Copy link
Contributor

@gnodet gnodet Jun 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we echo that somehow ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added reminder message at end

echo "=============================================================================="
echo "Release done, nothing got pushed (yet); please push changes with command below"
echo "$ git push origin mvnd-1.x --tags"
echo ""