Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleAppender omits stacktraces #696

Closed
oehme opened this issue Sep 29, 2022 · 2 comments
Closed

SimpleAppender omits stacktraces #696

oehme opened this issue Sep 29, 2022 · 2 comments
Labels
bug Something isn't working
Milestone
0.8.2

Comments

@oehme
Copy link
Contributor

oehme commented Sep 29, 2022

The SimpleAppender is designed to work like slf4j-simple, but it does not print any stacktraces. This is because it uses an unitialized ThrowableProxyConverter. This class has a lengthOption setting, which is 0 after instantiation, meaning that it will print 0 stack frames. This field is initialized to Integer.MAX_VALUE in the converter's start method, which is assumed to be called before it is used.

My suggestion would be to use ThrowableProxyUtil.asString instead.
@ppalaga
Copy link
Contributor

ppalaga commented Sep 30, 2022

Thanks for the report and suggestion, @oehme. Would you like to send a PR by any chance?

@gnodet gnodet added this to the 0.8.2 milestone Sep 30, 2022
@gnodet gnodet added the bug Something isn't working label Sep 30, 2022
gnodet added a commit to gnodet/mvnd that referenced this issue Oct 3, 2022
@gnodet
SimpleAppender omits stacktraces (fixes apache#696)
fa4e15c
gnodet added a commit to gnodet/mvnd that referenced this issue Oct 3, 2022
@gnodet
SimpleAppender omits stacktraces (fixes apache#696)
50f7300
@gnodet gnodet closed this as completed in 8c9d167 Oct 3, 2022
@oehme
Copy link
Contributor Author

oehme commented Oct 3, 2022

Thanks for fixing this so quickly!

theit pushed a commit to theit/maven-mvnd that referenced this issue Oct 5, 2022
@gnodet @theit
SimpleAppender omits stacktraces (fixes apache#696) (apache#700)
252262d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
0.8.2
Development

No branches or pull requests
3 participants
@gnodet @oehme @ppalaga