Bad string size caused by missing bytes in registry.bin

[lanmaoxinqing]

Hi,
We occasionally got a bad string size exception in our ci system showing below

Exception in thread "main" java.lang.IllegalStateException: Bad string size: 29801
	at org.mvndaemon.mvnd.common.DaemonRegistry.readString(DaemonRegistry.java:274)
	at org.mvndaemon.mvnd.common.DaemonRegistry.doUpdate(DaemonRegistry.java:204)
	at org.mvndaemon.mvnd.common.DaemonRegistry.read(DaemonRegistry.java:159)
	at org.mvndaemon.mvnd.common.DaemonRegistry.getAll(DaemonRegistry.java:101)
	at org.mvndaemon.mvnd.client.DaemonConnector.connect(DaemonConnector.java:97)
	at org.mvndaemon.mvnd.client.DefaultClient.execute(DefaultClient.java:233)
	at org.mvndaemon.mvnd.client.DefaultClient.main(DefaultClient.java:98)

In my situation, data keeps correct until reading the missing short bytes, which is the length of reason field, and then crashes. It may still work if the next short bytes is less than 1024 (but the DaemonStopEvent data breaks down since then)

    private String readString() {
        int sz = buffer.getShort();
        if (sz == -1) {
            return null;
        }
        if (sz < -1 || sz > 1024) {  // <-- here
            throw new IllegalStateException("Bad string size: " + sz);
        }
        byte[] buf = new byte[sz];
        buffer.get(buf);
        return new String(buf, StandardCharsets.UTF_8);
    }

what's worse, all later builds on the same ci machine will crash due to readString exception, until we delete the registry.bin file.

It happens in mvnd 0.4.1, but I think we still suffers in 0.5.1.
The problem registry.bin is in attach file below (I masked some working path info due to sensitive security policy), be sure using 0.4.1 to debug with it (token field add in 0.5.0)
registry.bin.zip

one guess is that mvnd crashed unexpectedly while FileChannel is flushing the file, so it closed and remains incomplete data in registry.bin.

[gnodet]

It does happen during CI builds:
1_windows.txt