Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bash completion #215

Closed
ppalaga opened this issue Nov 13, 2020 · 2 comments · Fixed by #255
Closed

Bash completion #215

ppalaga opened this issue Nov 13, 2020 · 2 comments · Fixed by #255
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ppalaga
Copy link
Contributor

ppalaga commented Nov 13, 2020

It looks like we could leverage https://github.com/juven/maven-bash-completion/blob/master/bash_completion.bash

We could either copy and adapt or contribute there.

We'd need to add our own commands like --stop, --status, etc. (I am not sure we should also add all -Dmvnd* props that can be passed on the command line.)

Once we have an adapted script somewhere, we need to figure out, how to activate it using sdkman and Homebrew.

@ppalaga
Copy link
Contributor Author

ppalaga commented Nov 30, 2020

Asked sdkman/sdkman-cli#831

@ppalaga ppalaga self-assigned this Dec 8, 2020
@ppalaga ppalaga changed the title Shell completion Bash completion Dec 10, 2020
ppalaga added a commit to ppalaga/mvnd that referenced this issue Dec 10, 2020
ppalaga added a commit to ppalaga/mvnd that referenced this issue Dec 10, 2020
ppalaga added a commit that referenced this issue Dec 10, 2020
@ppalaga
Copy link
Contributor Author

ppalaga commented Dec 10, 2020

The merged fix introduces a new mvnd option called --completion that accepts a shell name. bash is the only shell supported at this time.

If you are on Linux, you can activate the completion permanently as follows:

echo 'source <(mvnd --completion bash)' >> ~/.bashrc

@ppalaga ppalaga added this to the 0.2.0 milestone Dec 15, 2020
@ppalaga ppalaga added the enhancement New feature or request label Dec 15, 2020
famod added a commit to famod/mvnd that referenced this issue Dec 25, 2020
ppalaga pushed a commit that referenced this issue Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant