Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt out of implicit -T #132

Closed
jglick opened this issue Oct 23, 2020 · 3 comments · Fixed by #176
Closed

Opt out of implicit -T #132

jglick opened this issue Oct 23, 2020 · 3 comments · Fixed by #176
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@jglick
Copy link
Contributor

jglick commented Oct 23, 2020

I am not sure how I feel about the implicit -T argument being added by default, but there should at least be a user setting to disable it by default (without adding -T1 to every invocation):

  • Principle of least surprise. It should be possible to use mvnd as a drop-in replacement for mvn with as few risks as possible. Parallelized builds are not enabled by default in Maven, so if there are problems in mojos or POMs which are manifested only in this mode, it would effectively look like a bug in mvnd.
  • The dynamic console output was apparently invented with -T as the motivating use case, and there are reasons to not want it, as in Option to default to a simple log when using a single thread #116.
@gnodet gnodet added the enhancement New feature or request label Oct 26, 2020
@ppalaga ppalaga self-assigned this Oct 31, 2020
ppalaga added a commit to ppalaga/mvnd that referenced this issue Oct 31, 2020
@ppalaga ppalaga added this to the 0.0.12 milestone Oct 31, 2020
ppalaga added a commit to ppalaga/mvnd that referenced this issue Oct 31, 2020
@ppalaga
Copy link
Contributor

ppalaga commented Oct 31, 2020

#176 will allow storing your -T preference in ~/.m2/mvnd.properties:

mvnd.threads = 1

@famod
Copy link
Contributor

famod commented Oct 31, 2020

Good to have a config option for this!

What if a certain project cannot be built multi-threaded? I guess in this case one has to resort to passing -T1 for each run?

@ppalaga
Copy link
Contributor

ppalaga commented Oct 31, 2020

What if a certain project cannot be built multi-threaded? I guess in this case one has to resort to passing -T1 for each run?

Yes, currently, there is no better option.

If you mean that we should have a per-project config file, feel free to create a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants