Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should support core extensions #114

Closed
marcphilipp opened this issue Oct 20, 2020 · 7 comments
Closed

Should support core extensions #114

marcphilipp opened this issue Oct 20, 2020 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@marcphilipp
Copy link

marcphilipp commented Oct 20, 2020

Core extensions don't seem to get applied when using mvnd. Is that a known issue/limitation?

To reproduce simply clone https://github.com/gradle/maven-build-scan-quickstart, and run mvnd validate vs. ./mvnw validate. The latter prints a build scan link at the end, while the former does not.

@ppalaga
Copy link
Contributor

ppalaga commented Oct 20, 2020

This is an issue known solely thanks to your report :) Thanks!

@famod
Copy link
Contributor

famod commented Oct 20, 2020

Big 👍 from me as this would also enable the combination of mvnd and https://github.com/vackosar/gitflow-incremental-builder

@famod
Copy link
Contributor

famod commented Oct 21, 2020

It seems extensions registered in pom.xml via <extensions> or as plugins with <extensions>true</extensions> are not affected!

@ppalaga
Copy link
Contributor

ppalaga commented Oct 22, 2020

We should test with .mvnd/extensions.xml

@gnodet gnodet added the bug Something isn't working label Oct 26, 2020
@gnodet
Copy link
Contributor

gnodet commented Oct 29, 2020

Fwiw, extensions have been removed from DaemonMavenCli in the initial work to allow the container to be created and reused.

I'm going to check if we can bring that back somehow.

gnodet added a commit to gnodet/mvnd that referenced this issue Nov 2, 2020
gnodet added a commit to gnodet/mvnd that referenced this issue Nov 2, 2020
@gnodet
Copy link
Contributor

gnodet commented Nov 2, 2020

@marcphilipp fwiw, the Gradle extensions uses a non standard input handler, so even with #181 and a fix #180, this would not solve the usage of the Gradle extension. It would require a custom fix to provide an implementation of com.gradle.maven.extension.internal.dep.org.codehaus.plexus.components.interactivity that could delegate to the one that a fix for #180 would provide.

gnodet added a commit to gnodet/mvnd that referenced this issue Nov 2, 2020
@marcphilipp
Copy link
Author

@gnodet Thanks for looking into it! I'll take a closer look once #180 is resolved.

@gnodet gnodet closed this as completed Nov 10, 2020
@gnodet gnodet added this to the 0.0.12 milestone Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants