Skip to content

Commit

Permalink
More script changes (#1020)
Browse files Browse the repository at this point in the history
Changes:
* `release-build.sh`: Just do not push. This allows one to locally verify the outcome, and push (for now manually like `git push origin mvnd-1.x --tags`). Added reminder message.
* `release.yaml`: whenever mvn would resolve deps, make sure release settings XML is present. It does not stir anything if Maven is in Central, but as in this moment, maven is still staged only.
  • Loading branch information
cstamas authored Jun 14, 2024
1 parent c963ea4 commit 69b301e
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}

- name: 'Build source distribution'
run: ./mvnw clean verify -Psource-distribution -N -B -ntp -e
run: ./mvnw clean verify -Psource-distribution -N -B -ntp -e -s .mvn/release-settings.xml

- name: 'Upload artifact'
uses: actions/upload-artifact@v4
Expand Down
12 changes: 9 additions & 3 deletions build/release-build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ startup_check
# update version
mvn versions:set -DnewVersion=$VERSION

# udpate changelog
# update changelog
docker run -it --rm -v "$(pwd)":/usr/local/src/your-app githubchangeloggenerator/github-changelog-generator \
--user apache --project maven-mvnd --token $GITHUB_TOKEN --future-release $VERSION \
--exclude-tags early-access,0.9.0,1.0.0-m2,build-1.0.0-m2,1.0.0-m3
Expand All @@ -129,7 +129,7 @@ git commit -m "[release] Release $VERSION"

# Create and push tag
git tag $VERSION
git push origin $VERSION
# git push origin $VERSION
# Pushing a tag will trigger the CI to build the release and publish
# the artifacts on https://github.com/apache/maven-mvnd/releases

Expand All @@ -139,4 +139,10 @@ mvn versions:set -DnewVersion=$NEXT_VERSION
# commit
git add -A
git commit -m "Next is $NEXT_VERSION"
git push origin mvnd-1.x
# git push origin mvnd-1.x

# NOTE: Manually push once done: git push origin mvnd-1.x --tags
echo "=============================================================================="
echo "Release done, nothing got pushed (yet); please push changes with command below"
echo "$ git push origin mvnd-1.x --tags"
echo ""

0 comments on commit 69b301e

Please sign in to comment.