Migrate from Plexus to Sisu Guice #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-o
requested review from
cstamas,
gnodet and
slawekjaranowski
and removed request for
michael-o
gnodet
approved these changes
Nov 19, 2024
pom.xml
Outdated
Comment on lines
492
to
499
| <executions> | ||
| <execution> | ||
| <id>generate-index</id> | ||
| <goals> | ||
| <goal>main-index</goal> | ||
| </goals> | ||
| </execution> | ||
| </executions> |
There was a problem hiding this comment.
There is a definition in parent pom ....
https://github.com/apache/maven-parent/blob/master/pom.xml#L1014-L1027
with additional we execute plugin twice:
[INFO] --- sisu:0.9.0.M3:main-index (index-project) @ maven-javadoc-plugin ---
...
[INFO] --- sisu:0.9.0.M3:main-index (generate-index) @ maven-javadoc-plugin ---
There was a problem hiding this comment.
good catch. removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.