Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on plexus #63

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Remove dependency on plexus #63

merged 2 commits into from
Oct 4, 2023

Conversation

elharo
Copy link
Contributor

@elharo elharo commented Oct 1, 2023 •
edited
Loading

I tried to do this with pure Java 8, but debugging the Groovy in the integration tests was too painful.

@elharo elharo changed the title move plexus-utils to test scope and remove unused imports Remove dependency on plexus Oct 1, 2023
@elharo elharo requested a review from michael-o October 2, 2023 12:02
michael-o
michael-o approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate blanket imports. Leave as-is because this is a topic for another PR.

@elharo elharo merged commit 7934b48 into master Oct 4, 2023
9 checks passed
@elharo elharo deleted the plex branch October 4, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-o michael-o michael-o approved these changes

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elharo @michael-o @slawekjaranowski