Junit report - add required fields #4
Conversation
Signed-off-by: Slawomir Jaranowski <[email protected]>
Signed-off-by: Slawomir Jaranowski <[email protected]>
| @@ -1874,8 +1874,15 @@ private void writeJunitReport( BuildJob buildJob, String safeFileName, Execution | |||
| { | |||
| File reportFile = new File( reportsDirectory, "TEST-" + safeFileName + ".xml" ); | |||
| Xpp3Dom testsuite = new Xpp3Dom( "testsuite" ); | |||
| testsuite.setAttribute( "tests", "1" ); | |||
| testsuite.setAttribute("name", junitPackageName + "." + safeFileName); | |||
There was a problem hiding this comment.
pls follow the checkstyle as it is everywhere: spaces, thx
Most probably you did not run the build (mvn -P run-its verify) on this project, check for errors, thx.
|
@eolivelli |
| @@ -1874,8 +1874,15 @@ private void writeJunitReport( BuildJob buildJob, String safeFileName, Execution | |||
| { | |||
| File reportFile = new File( reportsDirectory, "TEST-" + safeFileName + ".xml" ); | |||
| Xpp3Dom testsuite = new Xpp3Dom( "testsuite" ); | |||
| testsuite.setAttribute( "tests", "1" ); | |||
There was a problem hiding this comment.
Sounds correct... why removing tests number?
There was a problem hiding this comment.
it was moved, together with other attributes - see line 1881
| @@ -1874,8 +1874,15 @@ private void writeJunitReport( BuildJob buildJob, String safeFileName, Execution | |||
| { | |||
| File reportFile = new File( reportsDirectory, "TEST-" + safeFileName + ".xml" ); | |||
| Xpp3Dom testsuite = new Xpp3Dom( "testsuite" ); | |||
| testsuite.setAttribute( "tests", "1" ); | |||
| testsuite.setAttribute("name", junitPackageName + "." + safeFileName); | |||
There was a problem hiding this comment.
testcase has the test name. This one should be only the package name as it's a suite?
There was a problem hiding this comment.
it is like in maven-surefire plugin, it is result after test with sonarqube - this is required to be set to something
Signed-off-by: Slawomir Jaranowski <[email protected]>
|
I got testsuite attributes from |
No description provided.