[MNG-7982] IT’s for transitive dependency management #379
Conversation
DidierLoiseau
force-pushed
the
feature/MNG-7982-transitive-dependency-management
branch
2 times, most recently
from
a70a77e
to
64e0c07
Compare
If <dependencyManagement> is transitive, its exclusions should be as well.
DidierLoiseau
force-pushed
the
feature/MNG-7982-transitive-dependency-management
branch
from
64e0c07
to
771f41f
Compare
| @@ -39,11 +40,13 @@ public MavenITmng4720DependencyManagementExclusionMergeTest() { | |||
| /** | |||
There was a problem hiding this comment.
Should I update the super() above? Maybe keep the old test for [2.0.6,4.0.0) and move these changes to a new test for [4.0.0,)?
I don’t know how this test suite is used for previous releases…
There was a problem hiding this comment.
It's not really used anymore. At least, we branched for Maven 3.x, not sure how we'll handle things for 4.0, 4.1, etc..., but I was actually considering merging ITs into maven to ease. I don't really see any good reason not to do that.
|
@DidierLoiseau could you align the branch names for this PR and apache/maven#1785, this will allow running #1785 using the new ITs, else it will use master. |
I see you have created #384 and apache/maven#1788, so I guess this isn’t necessary anymore? |
Right |
Main PR: apache/maven#1785
This PR provides integration tests for MNG-7982, implemented in apache/maven#1357, as well as the legacy (Maven 2/3) behavior.
Unfortunately these tests fail with Maven 4.0.0-beta-4 and the current master:
MavenITmng7982DependencyManagementTransitivityTest: the test shows that, currently, the transitive dependency management fails for moduled, but if you comment it out, you’ll see that it works fore, which is inconsistent – dependency management is ignored for just the first level of dependencies, not deeper layers.MavenITmng4720DependencyManagementExclusionMergeTestwas updated to show the behavior expected after MNG-7982: exclusions from dependency management in transitive dependencies should also be picked up.Both tests can be fixed by making
MavenSessionBuilderSupplier#getDependencyManager(boolean)return aTransitiveDependencyManagerwhen the parameter istrue, without breaking any other tests.See also my comment in MNG-5761 about this inconsistency.