Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MGPG-113] SignAndDeployFileMojo results in 401 #82

Merged
merged 2 commits into from
Mar 23, 2024

Conversation

cstamas
Copy link
Member

@cstamas cstamas commented Mar 23, 2024

The RemoteRepository was "bare", it has to be equipped with AuthenticationSelector to be able to perform authenticated deploys. Also, remove "layout" as since Maven 3.0 there is no other layout than "default".

Also, a bit of tidy up, layout is deprecated in Maven3 and is unused.


https://issues.apache.org/jira/browse/MGPG-113

The RemoteRepository was "bare", it has to be equipped
with AuthenticationSelector to be able to perform authenticated
deploys.

Also, a bit of tidy up, layout is deprecated in Maven3 and
is unused.

Signed-off-by: Tamas Cservenak <[email protected]>
@cstamas cstamas self-assigned this Mar 23, 2024
Comment on lines 146 to 149
*
* @deprecated Maven3 does not support "legacy" (Maven1) layout anymore. This parameter is unused.
*/
@Deprecated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to remove such parameters.

With deprecated - we will have warning about it - the similar will be than we remove it and someone will use it - warning will be emitted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@cstamas cstamas merged commit 528fab9 into apache:master Mar 23, 2024
19 checks passed
@cstamas cstamas deleted the MGPG-113 branch March 23, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants