Fix mismatching Parameter initial field values #418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I understand it correctly, if a Mojo parameter has a
@Parameter#defaultValue
, that value overwrites the initial value of the field (if any).This pull request therefore fixes two cases where the initial field value did not match the
@Parameter#defaultValue
, which could have lead to confusion.For
AbstractFromDependenciesMojo#failOnMissingClassifierArtifact
it seems this issue was accidentally introduced by 1592cdc#diff-b352be9b15d48a15ddf79e115c28c4cc776b7ec2662f553e189a978261d34881R100; the Javadoc had previouslydefault-value="true"
, which was matching the field valuetrue
, and was accidentally changed tofalse
.Though I am not going to adjust the default value to be
true
again since it has beenfalse
now for multiple years apparently.The test classes
TestUnpackDependenciesMojo
andTestCopyDependenciesMojo
had to be adjusted because they were apparently not creating the Mojo instances they way Maven would normally do and therefore were relying on the field values instead of thedefaultValue
. For example when using the followingpom.xml
and runningmvn package
, you will see that the Dependency Plugin does not report an error for a missing classifier by default:pom.xml
(click to expand)For
CopyDependenciesMojo#copyPom
it looks like it always had this mismatch since it was added by 32a29e6Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MDEP-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MDEP-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.