-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MDEP-941] Deprecate dependency:sources in favor of dependency:resolv… #411
Conversation
...main/java/org/apache/maven/plugins/dependency/resolvers/OldResolveDependencySourcesMojo.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/maven/plugins/dependency/resolvers/OldResolveDependencySourcesMojo.java
Outdated
Show resolved
Hide resolved
…e-sources This closes #411
* | ||
* @author <a href="mailto:[email protected]">Brian Fox</a> | ||
* @since 2.0-alpha2 | ||
* @deprecated in favor of {@code resolve-sources} goal and will be removed in a future version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This message fails to explain that the goals are functionally identical, differing only in name. I looked through the plugin site and FAQ trying to find some explanation of why I should switch and what parameters I would need to change, finally coming across this PR via code archaeology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What difference does it make for that matter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am just pointing out that when as a Maven user you see this warning in your build, you may spend time trying to figure out what all you need to do in order to migrate to the new goal, when in fact you need do nothing beyond add resolve-
to your command.
…e-sources
This closes #411
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MDEP-XXX] - Fixes bug in ApproximateQuantiles
,where you replace
MDEP-XXX
with the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verify
to make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify
).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.