Code

Test review Core J-S, #259#914

Code

Merged

paulirwin merged 29 commits intoapache:masterapache/lucenenet:masterfrom paulirwin:test-review-j-spaulirwin/lucene.net:test-review-j-sCopy head branch name to clipboardMar 10, 2024

+1,414-1,728

Commits

Commits on Jan 22, 2024

• Formatting and remove extraneous comment in Search/Payloads, apache#259

  paulirwin

  committed
  68d21e5

• Array formatting in Search/Similarities to match upstream

  paulirwin

  committed
  2fc6340

• Search/Spans formatting cleanup, use singletons for parameterless/captureless anonymous classes

  paulirwin

  committed
  da352d2

• Code cleanup in Search/B-TestB tests

  paulirwin

  committed
  743808c

Commits on Jan 23, 2024

• Search/TestC code cleanup and allocation improvements

  paulirwin

  committed
  bd1b355

• Search/TestD-TestE code cleanup

  paulirwin

  committed
  a6da17e

Commits on Jan 24, 2024

• Test review TestF-TestL, apache#259

  paulirwin

  committed
  fcbdd92

Commits on Jan 25, 2024

• Test review for rest of Search, apache#259

  paulirwin

  committed
  1f84445

• Test review of Store, apache#259

  paulirwin

  committed
  65954a9

Commits on Feb 15, 2024

• Finish J-S test cleanup

  paulirwin

  committed
  531797f

• Merge branch 'master' into test-review-j-s

  paulirwin

  committed
  77cf172

Commits on Feb 16, 2024

• Fix .NET FX build failure due to missing import

  paulirwin

  committed
  5867518

Commits on Feb 24, 2024

• Use CompareToOrdinal instead of string.Compare

  paulirwin

  committed
  1e00806

• Change Array.Empty<T> to Arrays.Empty<T> until apache#916 is done in a separate PR

  paulirwin

  committed
  e72dd6b

• Null-safe disposal of resources in TestSpansAdvanced

  paulirwin

  committed
  ef87a7d

• Make TestSpansAdvanced.AssertHits static to match upstream Java code

  paulirwin

  committed
  715534c

• Use Arrays.Empty<T> in TestBoolean2 instead of Array.Empty<T>

  paulirwin

  committed
  e6cb611

• Revert static instance of MockScorer in TestCachingCollector

  paulirwin

  committed
  0ffe758

• Revert static instances of NoOpCollector in TestCachingCollector

  paulirwin

  committed
  b986d1d

• Fix seealso cref to CheckHits.CheckNoMatchExplanations

  paulirwin

  committed
  e564fe6

• Fix ticks math in RandomGen.LuceneDate

  paulirwin

  committed
  592c963

• Fix XML doc comment paragraph tag in TestFieldCacheRangeFilter

  paulirwin

  committed
  e00ad3c

• Revert static instance of AnalyzerAnonymousClass in TestPhraseQuery

  paulirwin

  committed
  e035222

• Comment out TestScorerPerf.terms to prevent unused warning

  paulirwin

  committed
  32e84b2

Commits on Feb 25, 2024

• Remove use of Convert.ToInt32 which boxes in CheckHits

  paulirwin

  committed
  12ef921

• Specify culture for Convert.ToInt32

  paulirwin

  committed
  956c280

• Fix spelling of TransactionalThreadInterrupt class

  paulirwin

  committed
  a4b5a61

• Add back redundant override of TestRegexps in case some test runners don't report failures correctly

  paulirwin

  committed
  5498084

Commits on Mar 10, 2024

• Remove unused ConcurrentDictionaryWrapper type

  paulirwin

  committed
  53bb736