Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Updates / Added reference to Microsoft.NETFramework.ReferenceAssemblies #593

Merged
merged 2 commits into from
Jan 5, 2022

Conversation

NightOwl888
Copy link
Contributor

  • Updated the Directory.Build files to move the reference to build/Dependencies.props to a single location, rather than being referenced in every project file
  • Migrated the PackageReference elements that were introduced in Added Source Link Support + Documentation #592 to Directory.Build.props where they have access to the properties in build/Dependencies.props
  • Added reference to Microsoft.NETFramework.ReferenceAssemblies
  • Updated README.md to indicate that the .NET Framework 4.8 Developer Pack is no longer a prerequisite for the build

…it can conditionally select package reference versions based on target framework. Moved Source Link references here, too so the version numbers can be resolved.
…NETFramework.ReferenceAssemblies, which removes the prerequisite of .NET Framework 4.8 Developer Pack to run builds.
@NightOwl888 NightOwl888 merged commit 0a2c266 into apache:master Jan 5, 2022
@NightOwl888 NightOwl888 added this to the 4.8.0-beta00016 milestone Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant