-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PersianStemmer #571
Add PersianStemmer #571
Conversation
Thanks for the PR. You have done a great job following conventions and putting this together. However, Options
Either way, it would be great to keep this PR open and to report the status of the contribution to Lucene back here so we can track the progress and learn about how these sort of approvals work. We will merge it once the Lucene team makes the final approval. |
Hi Shad, |
Great. Let us know if you need help with that. The |
I made a pull request 3 months ago. And I'm waiting for them :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this. There are just a few minor changes to do before this can be merged.
src/Lucene.Net.Analysis.Common/Analysis/Fa/PersianStemFilter.cs
Outdated
Show resolved
Hide resolved
src/Lucene.Net.Analysis.Common/Analysis/Fa/PersianStemFilterFactory.cs
Outdated
Show resolved
Hide resolved
src/Lucene.Net.Tests.Analysis.Common/Analysis/Fa/TestPersianStemFilter.cs
Outdated
Show resolved
Hide resolved
src/Lucene.Net.Tests.Analysis.Common/Analysis/Fa/TestPersianStemFilter.cs
Outdated
Show resolved
Hide resolved
src/Lucene.Net.Tests.Analysis.Common/Analysis/Fa/TestPersianStemFilter.cs
Show resolved
Hide resolved
src/Lucene.Net.Tests.Analysis.Common/Analysis/Fa/TestPersianStemFilter.cs
Outdated
Show resolved
Hide resolved
src/Lucene.Net.Tests.Analysis.Common/Analysis/Fa/TestPersianStemFilter.cs
Outdated
Show resolved
Hide resolved
Hi Shad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay. There is one more requested change that has not been resolved, calling Arrays.Equals()
to do the char[]
comparison.
@raminmjj - Looks like the Lucene team decided not to make the I will make the same changes to Lucene.NET in a new PR. |
as was done in apache/lucene#904. Changed TestPersianStemFilter to use mocks.
Hi,
We removed |
… was done in apache/lucene#904. Changed TestPersianStemFilter to use mocks.
No description provided.