Fix for analysis culture sensitivity and surrogate pair support #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing invariant culture to do so again. J2N's Character class default is to use the current culture, which had changed from the prior Character class that used invariant culture. Fixes TestICUFoldingFilter::TestRandomStrings().
29 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several Analysis.Common classes that were broken since 4.8.0-beta00008 in commit b733c4d because the
Characterclass was changed to J2N which uses the current culture by default instead of Java's default of invariant culture for uppercasing and lowercasing. As a result, these classes were unintentionally modified in behavior. This patch reverts them back to the invariant culture (or specific culture for the class, where applicable).Also, a bug was discovered where a cast from
inttocharcaused many analysis classes to incorrectly process surrogate pairs, which this addresses.We were also able to revert the
TurkishLowercaseFilterback to its original implementation by utilizingJ2N.Characterto do the heavy lifting instead ofSystem.Char.