Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some Support unit tests, #920 #1093

Merged
merged 7 commits into from
Jan 12, 2025
Merged

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Adds some Support unit tests.

Partial #920

Description

This adds unit tests for the Support namespace types listed in #920 that don't need Apache Harmony or other test considerations, including:

  • IndexableFieldExtensions
  • ByteArrayOutputStream
  • CastTo
  • ListExtensions
  • AssemblyUtils
  • DictionaryExtensions

@paulirwin paulirwin added the notes:improvement An enhancement to an existing feature label Jan 12, 2025
Copy link
Contributor

@NightOwl888 NightOwl888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks good.

@paulirwin paulirwin merged commit 24fb64b into apache:master Jan 12, 2025
8 checks passed
@paulirwin paulirwin deleted the issue/920 branch January 12, 2025 02:58
@paulirwin paulirwin mentioned this pull request Jan 12, 2025
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:improvement An enhancement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants