Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TestICUFoldingFilterFactory.Test #1045

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Conversation

paulirwin
Copy link
Contributor

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a change, please open an issue to discuss the change or find an existing issue.

Removes [AwaitsFix] from TestICUFoldingFilterFactory.Test

Related #269

Description

This test passes on Ubuntu 24.04 in my local testing. It was noted that it failed on Ubuntu 18.04 on GitHub Actions, but that is no longer a supported distribution for any of our current targets. This removes the [AwaitsFix] from this test to see if it passes in GitHub Actions on Ubuntu today, and if so, we can merge this to re-enable the test.

@paulirwin paulirwin added the notes:ignore Don't show this PR in the Release Notes label Nov 25, 2024
@paulirwin paulirwin added this to the 4.8.0-beta00018 milestone Nov 25, 2024
@paulirwin paulirwin merged commit 72123b0 into apache:master Nov 25, 2024
6 checks passed
@paulirwin paulirwin deleted the issue/269-2 branch November 25, 2024 16:52
@paulirwin paulirwin mentioned this pull request Nov 25, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notes:ignore Don't show this PR in the Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant