Fixes failing test case for TestOrdinalMap.testRamBytesUsed #13421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pseudo-nymous
changed the title
jpountz
approved these changes
May 27, 2024
| if (o == LongValues.ZEROES || o == LongValues.IDENTITY) { | ||
| if (o == LongValues.ZEROES | ||
| || o == LongValues.IDENTITY | ||
| || o == PackedInts.NullReader.DEFAULT_PACKED_LONG_VALUES_PAGE_SIZE) { |
There was a problem hiding this comment.
Nit: Can you replace this with PackedInts.NullReader.forCount(PackedLongValues.DEFAULT_PAGE_SIZE) and make DEFAULT_PACKED_LONG_VALUES_PAGE_SIZE private again?
There was a problem hiding this comment.
Sure. Thanks for quick review.
jpountz
approved these changes
May 28, 2024
jpountz
pushed a commit
that referenced
this pull request
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #13372
TestOrdinalMap#testRamBytesUsed was failing for the case when there are multiple Default instances for PackedInts.NullReader. Currently, we return 0 when the instance is built with default size i.e. 256. Ref: org.apache.lucene.util.packed.PackedInts.NullReader#ramBytesUsed
But this was not accounted for in the Accumulator being used. Made changes to skip the object if the reader is of default static instance.
Passes failing UT.
./gradlew :lucene:core:test --tests "org.apache.lucene.index.TestOrdinalMap.testRamBytesUsed" -Ptests.seed=55680AD930225FC5 -Ptests.nightly=true