Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent parent field from added to existing index #13016

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

s1monw
Copy link
Member

@s1monw s1monw commented Jan 16, 2024

This change prevents users from adding a parent field to an existing index. Parent field must be added before any documents are added to the index to prevent documents without the parent field from being indexed and later to be treated as child documents upon merge.

Relates to #12829

This change prevents users from adding a parent field to an existing index.
Parent field must be added before any documents are added to the index to
prevent documents without the parent field from being indexed and later
to be treated as child documents upon merge.

Relates to apache#12829
@s1monw s1monw requested a review from jpountz January 16, 2024 09:09
Copy link
Contributor

@jpountz jpountz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@s1monw s1monw merged commit 340d9d2 into apache:main Jan 16, 2024
4 checks passed
@s1monw s1monw deleted the prevent_adding_parent_after_the_fact branch January 16, 2024 09:53
slow-J pushed a commit to slow-J/lucene that referenced this pull request Jan 16, 2024
This change prevents users from adding a parent field to an existing index.
Parent field must be added before any documents are added to the index to
prevent documents without the parent field from being indexed and later
to be treated as child documents upon merge.

Relates to apache#12829
s1monw added a commit that referenced this pull request Jan 17, 2024
This change prevents users from adding a parent field to an existing index.
Parent field must be added before any documents are added to the index to
prevent documents without the parent field from being indexed and later
to be treated as child documents upon merge.

Relates to #12829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants