Backport #12829 to 9.x #13013
Closed
Backport #12829 to 9.x #13013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today index sorting will most likely break document blocks added with `IndexWriter#addDocuments(...)` and `#updateDocuments(...)` since the index sorter has no indication of what documents are part of a block. This change automatically adds a marker field to parent documents if configured in `IWC`. These marker documents are optional unless document blocks are indexed and index sorting is configured. In this case indexing blocks will fail unless a parent field is configured. Index sorting will preserve document blocks during sort. Documents within a block not be reordered by the sorting algorithm and will sort along side their parent documents. Relates to apache#12711
A parent field can now safely be added to indices that are created on or after 9.9.x that have no doc blocks as well as newly created indices. Adding a parent field to older indices is not permitted. Relates to apache#12829
|
ups I made a bad assumpion. I need to revisit this... |
|
this doesn't work as I expected. I will close this one for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport PR for #12829. It add the optional ability to index parent fields in 9.x. While 9.x can still use index sorting with doc blocks without using a parent field this allows users to migrate to this mandatory feature earlier than 10.x. Only indices with min segment version 9.9 and older will be able to be configured with a parent field. These versions record if the index already has blocks which makes it safe to add the parent field after the fact.