Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestIndexWriterOnVMError.testUnknownError fails with unclosed file handles #13434

Closed
benwtrent opened this issue May 29, 2024 · 1 comment · Fixed by #13436
Closed

TestIndexWriterOnVMError.testUnknownError fails with unclosed file handles #13434

benwtrent opened this issue May 29, 2024 · 1 comment · Fixed by #13436
Labels
type:test

Comments

@benwtrent
Copy link
Member

Description

TestIndexWriterOnVMError.testUnknownError fails reliably with unclosed file handles. It fails in 9x and on main.

On main, the teset name is instead TestIndexWriterOnError.testUnknownError

Gradle command to reproduce

./gradlew test --tests TestIndexWriterOnVMError.testUnknownError -Dtests.seed=8701E0F810C16F88 -Dtests.nightly=true -Dtests.locale=fr-GA -Dtests.timezone=America/Tortola -Dtests.asserts=true -Dtests.file.encoding=UTF-8
@benwtrent
Copy link
Member Author

Also note,

gradlew test --tests TestIndexWriterOnError.testIOError -Dtests.seed=D02646EAEA66A6CB -Dtests.nightly=true -Dtests.locale=ff-Adlm-BF -Dtests.timezone=Europe/Andorra -Dtests.asserts=true -Dtests.file.encoding=UTF-8

Fails on main as well.

jpountz added a commit to jpountz/lucene that referenced this issue May 29, 2024
@jpountz
Fix TestIndexWriterOnError.testIOError failure.
584471f 
Pull request apache#13406 inadvertly broke Lucene's handling of tragic exceptions by
stopping after the first `DocValuesProducer` whose `close()` calls throws an
exception, instead of keeping calling `close()` on further producers in the
list.

This moves back to the previous behavior.

Closes apache#13434
@jpountz jpountz mentioned this issue May 29, 2024
Merged
jpountz added a commit that referenced this issue May 29, 2024
@jpountz
Fix TestIndexWriterOnError.testIOError failure. (#13436)
750a7c4 
Pull request #13406 inadvertly broke Lucene's handling of tragic exceptions by
stopping after the first `DocValuesProducer` whose `close()` calls throws an
exception, instead of keeping calling `close()` on further producers in the
list.

This moves back to the previous behavior.

Closes #13434
jpountz added a commit that referenced this issue May 29, 2024
@jpountz
Fix TestIndexWriterOnError.testIOError failure. (#13436)
c5ea94f 
Pull request #13406 inadvertly broke Lucene's handling of tragic exceptions by
stopping after the first `DocValuesProducer` whose `close()` calls throws an
exception, instead of keeping calling `close()` on further producers in the
list.

This moves back to the previous behavior.

Closes #13434
jpountz added a commit that referenced this issue May 29, 2024
@jpountz
Fix TestIndexWriterOnError.testIOError failure. (#13436)
ac4ccbf 
Pull request #13406 inadvertly broke Lucene's handling of tragic exceptions by
stopping after the first `DocValuesProducer` whose `close()` calls throws an
exception, instead of keeping calling `close()` on further producers in the
list.

This moves back to the previous behavior.

Closes #13434
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:test
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TestIndexWriterOnError.testIOError failure. jpountz/lucene
1 participant
@benwtrent