Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python backward compat scripts need updating #13094

Closed
dweiss opened this issue Feb 11, 2024 · 0 comments
Closed

Python backward compat scripts need updating #13094

dweiss opened this issue Feb 11, 2024 · 0 comments
Labels
type:bug
Milestone
9.10.0

Comments

@dweiss
Copy link
Contributor

dweiss commented Feb 11, 2024

Description

As @HoustonPutman wrote on the mailing list:

So I just finished the 8.11.3 release, and had some problems with the back-compat testing code. Obviously the ant/gradle switch and jdk versions meant that I had to do a lot of it manually, but I'm pretty sure the regex matching in the update_backcompat_tests() function in addBackcompatIndexes.py was broken by this commit.

A review of these release scripts would be needed to make sure no regressions lurk after #13046

Version and environment details

No response
@dweiss dweiss added this to the 9.10.0 milestone Feb 11, 2024
s1monw added a commit to s1monw/lucene that referenced this issue Feb 12, 2024
@s1monw
Fix addBackcompatIndexes.py to properly generate missing versions
5a4a18d 
In apache#13046 several changes broke the addBackcompatIndexes.py script
to properly add and test the unreleased version. This updates the
script to again properly add the new version.

Closes apache#13094
@s1monw s1monw mentioned this issue Feb 12, 2024
Merged
s1monw added a commit that referenced this issue Feb 14, 2024
@s1monw @dweiss
Fix addBackcompatIndexes.py to properly generate missing versions (#1…
81a7c40 
…3095)

In #13046 several changes broke the addBackcompatIndexes.py script
to properly add and test the unreleased version. This updates the
script to again properly add the new version.

Closes #13094

Co-authored-by: Dawid Weiss <[email protected]>
@s1monw s1monw closed this as completed in c9e4434 Feb 14, 2024
asfgit pushed a commit that referenced this issue Feb 20, 2024
@s1monw @dweiss @jpountz
Fix addBackcompatIndexes.py to properly generate missing versions (#1…
28b04c2 
…3095)

In #13046 several changes broke the addBackcompatIndexes.py script
to properly add and test the unreleased version. This updates the
script to again properly add the new version.

Closes #13094

Co-authored-by: Dawid Weiss <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug
Projects
None yet
Milestone
9.10.0
Development

No branches or pull requests
1 participant
@dweiss