-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
java.lang.AssertionError in backward compat tests ("failed to parse ... as date") #13073
Comments
The embedded "linedocsfile" (europarl) has a different date field format compared to the "large" enwiki used on jenkins.
After #13046, TestIndexSortBackwardsCompatibility tries to parse the date and fails because it only recognizes "yyyy-MM-dd". I wonder what the best fix here should be - make the test recognize both date format or correct the test-resource-creation script and make dates there more consistent? I think correcting the test will be simpler... |
…another plain term query right below it (body:the) so I don't think it hurts much. apache#13073
There was actually just a single assertion that caused the problems. I've just remove it since it seems to be duplicated anyway with a term (body:the) that exists in both data sets. There is a marginal possibility of these tests failing in the future if the test resources change. Don't know if it's worth considering. |
@dweiss These tests never ran with the nightly provided line docs. I think the fix is ok for this purpose since the we just now started to run tests against current version. We can add a check on top if the version we are testing is the current version and only then allow the leniency. WDYT? |
I'm not sure what you're referring to. :) Please feel free to tweak - I just wanted jenkins to quiet down because it started failing. |
Description
These failures do reproduce but you need the linedocsfile. I'll take a look.
Version and environment details
No response
The text was updated successfully, but these errors were encountered: