Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java.lang.AssertionError in backward compat tests ("failed to parse ... as date") #13073

Closed
dweiss opened this issue Feb 5, 2024 · 5 comments · Fixed by #13075
Closed

java.lang.AssertionError in backward compat tests ("failed to parse ... as date") #13073

dweiss opened this issue Feb 5, 2024 · 5 comments · Fixed by #13075
Assignees
Milestone

Comments

@dweiss
Copy link
Contributor

dweiss commented Feb 5, 2024

Description

These failures do reproduce but you need the linedocsfile. I'll take a look.

Version and environment details

No response

@dweiss
Copy link
Contributor Author

dweiss commented Feb 5, 2024

The embedded "linedocsfile" (europarl) has a different date field format compared to the "large" enwiki used on jenkins.

(1)	2004-03-30	Istituzioni europee proteggerlo in tutti i campi.   [...]
APL (codepage)	11-JAN-2010 16:54:37.000	 languages.  From a user's standpoint

After #13046, TestIndexSortBackwardsCompatibility tries to parse the date and fails because it only recognizes "yyyy-MM-dd".

I wonder what the best fix here should be - make the test recognize both date format or correct the test-resource-creation script and make dates there more consistent?

I think correcting the test will be simpler...

@dweiss
Copy link
Contributor Author

dweiss commented Feb 5, 2024

@s1monw - some of those assertions added in #13046 only hold for the built-in europarl. I fixed date parsing but I'm not sure how to deal with the problem that the line resource can be different. Thoughts?

dweiss added a commit to dweiss/lucene that referenced this issue Feb 5, 2024
…another plain term query right below it (body:the) so I don't think it hurts much. apache#13073
@dweiss
Copy link
Contributor Author

dweiss commented Feb 5, 2024

There was actually just a single assertion that caused the problems. I've just remove it since it seems to be duplicated anyway with a term (body:the) that exists in both data sets. There is a marginal possibility of these tests failing in the future if the test resources change. Don't know if it's worth considering.

@dweiss dweiss added this to the 9.10.0 milestone Feb 5, 2024
@s1monw
Copy link
Member

s1monw commented Feb 12, 2024

@s1monw - some of those assertions added in #13046 only hold for the built-in europarl. I fixed date parsing but I'm not sure how to deal with the problem that the line resource can be different. Thoughts?

@dweiss These tests never ran with the nightly provided line docs. I think the fix is ok for this purpose since the we just now started to run tests against current version. We can add a check on top if the version we are testing is the current version and only then allow the leniency. WDYT?

@dweiss
Copy link
Contributor Author

dweiss commented Feb 12, 2024

I'm not sure what you're referring to. :) Please feel free to tweak - I just wanted jenkins to quiet down because it started failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants