SOLR-12708: Aggregate failures from downstream async jobs; add error … #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…handling for RestoreCmd
manokovacs
force-pushed
the
SOLR-12708
branch
from
aa7f9e5 to
16558ee
Compare
tflobbe
reviewed
Feb 13, 2019
| ocmh.addReplica(clusterState, new ZkNodeProps(propMap), new NamedList(), null); | ||
| final NamedList addResult = new NamedList(); | ||
| ocmh.addReplica(clusterState, new ZkNodeProps(propMap), addResult, () -> { | ||
| countDownLatch.countDown(); |
There was a problem hiding this comment.
I think we should move this to the end of the callback, or there can be a race condition
|
|
||
| boolean allIsDone = countDownLatch.await(1, TimeUnit.HOURS); | ||
| if (!allIsDone) { | ||
| throw new TimeoutException("Initial replicas were not created within 10 minutes. Timing out."); |
There was a problem hiding this comment.
Outdated error, this is now 1 hour
| @@ -0,0 +1,29 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
There was a problem hiding this comment.
Maybe there is a way to not have to create this new configset? either use the Config API, or the configset API, or maybe just updating one file? or maybe set a system property that one of the existing configsets will use to something invalid?
|
Closing since JIRA is closed |
zacharymorn
added a commit
to zacharymorn/lucene-solr
that referenced
this pull request
Jan 6, 2022
…calculation (apache#444) (cherry picked from commit 07ee3ba83a4c9f3abc24bf9d3fbb3c3102c4a102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…handling for RestoreCmd