-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate reproducibility check workflow #271
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds two outputs to both the `deploy-release-reusable` and `deploy-snapshot-reusable` workflows: - `project-version`: contains the version of the deployed project. - `project-repository-url`: contains the URL of the Nexus repository, where the artifacts were deployed. [It also fixes a small YAML syntax error, ignored by GitHub, but reported by IDEA]
The version of the project is not necessary, since it should be hardcoded in the `pom.xml`. We replace `project-repository-url` with `nexus-url` to be more coherent with the name of the environment variable.
Adds a reproducibility check workflow based on a Nexus repository and not the local Maven repo. We also deprecate the reproducibility check in `build-reusable.yaml`.
This prevents name collisions if `build-reusable` is called multiple times.
2 tasks
Before reviewing this, please check #270 on which this PR is based. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a reproducibility check workflow based on a Nexus repository and not the local Maven repo.
We also deprecate the reproducibility check in
build-reusable.yaml
.