Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ban wildcard imports #63

Closed
ppkarwasz opened this issue Nov 22, 2023 · 0 comments · Fixed by #94
Closed

Ban wildcard imports #63

ppkarwasz opened this issue Nov 22, 2023 · 0 comments · Fixed by #94
Assignees
@ppkarwasz
Labels
enhancement
Milestone
10.6.0

Comments

@ppkarwasz
Copy link
Contributor

An inconsistent usage of wildcard imports causes problems when we compare multiple release branches.

Since our old Style Guide bans their usage too, we should add a style check that fails the build in their presence. We can use the Maven Enforcer Rule skuzzle/restrict-imports-enforcer-rule for example.
@ppkarwasz ppkarwasz mentioned this issue Nov 22, 2023
Merged
@vy vy added this to the 10.5.0 milestone Nov 22, 2023
@vy vy removed this from the 10.5.0 milestone Jan 5, 2024
@vy vy added the enhancement label Jan 5, 2024
@ppkarwasz ppkarwasz self-assigned this Jan 9, 2024
ppkarwasz added a commit to ppkarwasz/logging-parent that referenced this issue Jan 10, 2024
@ppkarwasz
Ban wildcard imports
233d3d6 
Add rule to ban wildcard imports. Wildcard imports are often the only
difference between branches and they can not easily be expanded by
Spotless.

Fixes apache#63.
@ppkarwasz ppkarwasz mentioned this issue Jan 10, 2024
Merged
@ppkarwasz ppkarwasz added this to the 10.6.0 milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ppkarwasz ppkarwasz

Labels
enhancement
Projects
None yet
Milestone
10.6.0
Development

Successfully merging a pull request may close this issue.

Ban wildcard imports ppkarwasz/logging-parent
2 participants
@vy @ppkarwasz