Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve overwritability of BND configuration #39

Closed
ppkarwasz opened this issue Oct 4, 2023 · 0 comments · Fixed by #40
Closed

Improve overwritability of BND configuration #39

ppkarwasz opened this issue Oct 4, 2023 · 0 comments · Fixed by #40
Labels
bug

Comments

@ppkarwasz
Copy link
Contributor

ppkarwasz commented Oct 4, 2023 •
edited
Loading

Right now logging-parent provides two knobs to overwrite BND's generated OSGi package imports and JPMS module requirements:

  • <bnd-extra-package-options> allows to overwrite OSGi Import-Package statements,
  • <bnd-extra-module-options> allows to overwrite JPMS module requirements.

However these macros appear last in the definition of -jpms-module-info-options, which prevents child POMs from redefining the keys (like org.apache.logging.log4j) that are already defined in logging-parent.
@ppkarwasz ppkarwasz added the bug label Oct 4, 2023
ppkarwasz added a commit to ppkarwasz/logging-parent that referenced this issue Oct 4, 2023
@ppkarwasz
Improve overridability of BND configuration
1d2b949 
Closes apache#39.
@ppkarwasz ppkarwasz mentioned this issue Oct 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve overridability of BND configuration ppkarwasz/logging-parent
1 participant
@ppkarwasz