Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AdoNetAppender using npgsql once again. #77

Merged
merged 1 commit into from
Nov 23, 2021

Conversation

NicholasNoise
Copy link

Same bug as #71.
[email protected] (above 4.* in general) completely destroys adonet appender.

3.* fails to prepare command but allows to execute it.
4+ fails to prepare and to execute.

@NicholasNoise
Copy link
Author

@fluffynuts 2.0.14 pretty please? :)

Copy link
Contributor

@fluffynuts fluffynuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I have another small issue I'd like to include in a release, but not sure exactly when I'll get to it; hopefully sooner rather than later.

@fluffynuts fluffynuts merged commit 86fcc53 into apache:master Nov 23, 2021
@fluffynuts fluffynuts deleted the fix-npgsql branch November 23, 2021 10:38
@NicholasNoise
Copy link
Author

Thank you!
Patiently waiting for upcoming release

@dskantz
Copy link

dskantz commented Mar 30, 2023

This seems to have broken AdoNetAppender with Microsoft SQL Server. I have no logged events in the database after upgrading from 2.0.13 to 2.0.14. Did you test it on a SQL Server?

@fluffynuts
Copy link
Contributor

@dskantz no, I didn't, because I don't always have every possible database server installed. I believe I may have a fix in the pipeline, if I could allocate time to this. In the mean-time, I suggest downgrading to 2.0.13.

@dskantz
Copy link

dskantz commented Mar 30, 2023

@fluffynuts, great! Ping me in the PR if you want me to try it out on SQL Server before you merge. Well, at least on 2019.

@fluffynuts
Copy link
Contributor

@fluffynuts, great! Ping me in the PR if you want me to try it out on SQL Server before you merge. Well, at least on 2019.

You could try a build from master if you're up for it. At least it could confirm or deny whether it's fixed. If not and you're really motivated, fix & pr 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants