Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bumped NUnit to 4.2.2 #200

Merged
merged 3 commits into from
Oct 22, 2024
Merged

bumped NUnit to 4.2.2 #200

merged 3 commits into from
Oct 22, 2024

Conversation

FreeAndNil
Copy link
Contributor

  • added NUnit.Analyzers before moving to NUnit 4
  • switched to NUnit 4.2.2

@FreeAndNil FreeAndNil added this to the 3.0.3 milestone Oct 22, 2024
fluffynuts
fluffynuts approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@fluffynuts fluffynuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; just a suggestion around replacing Assert.Throws, but it's not imperative.

src/log4net.Tests/Util/CyclicBufferTest.cs Outdated Show resolved Hide resolved
@FreeAndNil FreeAndNil merged commit b008475 into master Oct 22, 2024
@FreeAndNil FreeAndNil deleted the Feature/NUnitBump branch October 22, 2024 10:44
FreeAndNil added a commit that referenced this pull request Oct 23, 2024
@FreeAndNil
update release notes for #200 & #201
ebbd22c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fluffynuts fluffynuts fluffynuts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@FreeAndNil @fluffynuts