Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dotnet test Command Not Recognizing NUnit3TestAdapter #164

Conversation

mobilebilly
Copy link
Contributor

Fix for Issue #109

This fix addresses the issue where the dotnet test command cannot recognize the NUnit3TestAdapter in existing ItemGroup elements.

Changes Made:

Moved the reference to NUnit3TestAdapter to an ItemGroup without a TargetFramework condition.

Move reference to NUnit3TestAdapter to ItemGroup without TargetFramework condition
@FreeAndNil FreeAndNil changed the base branch from master to Feature/111-Dropping-support-for-older-runtimes August 3, 2024 18:19
@FreeAndNil
Copy link
Contributor

@mobilebilly Thank you very much for your contribution.
I retargeted you pull request to Feature/111... because this is our current development branch for 3.0.0.
Can you please fix the conflicts and test the changes?

@FreeAndNil FreeAndNil self-requested a review August 3, 2024 18:21
@FreeAndNil FreeAndNil added this to the 3.0.0 milestone Aug 3, 2024
@mobilebilly
Copy link
Contributor Author

@FreeAndNil , no problem.
The conflicts have been fixed, and my branch is now up-to-date with the latest changes from the upstream branch Feature/111....
Please review the updated pull request and let me know if there are any further changes needed.

Copy link
Contributor

@FreeAndNil FreeAndNil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust as proposed, then we can merge.

src/log4net.Tests/log4net.Tests.csproj Show resolved Hide resolved
Set IsTestProject to true and clean up garbage from old project file.
@mobilebilly
Copy link
Contributor Author

@FreeAndNil, the additional change in the test project is done. thank you

Copy link
Contributor

@FreeAndNil FreeAndNil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot.

@FreeAndNil FreeAndNil merged commit 60d4fbc into apache:Feature/111-Dropping-support-for-older-runtimes Aug 5, 2024
FreeAndNil added a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants