-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove obsolete properties, methods, and classes for 3.0 #138
Remove obsolete properties, methods, and classes for 3.0 #138
Conversation
…ormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (apache#124).
For #125 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot.
Just one question.
I've noted the breaking changes in #125 (comment)
7e93b50
to
6d23e81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
202bb5c
into
apache:Feature/111-Dropping-support-for-older-runtimes
@erikmav because of https://learn.microsoft.com/en-us/dotnet/standard/serialization/binaryformatter-security-guide we think about removing ISerializable and [Serializable] (at least for netstandard). |
Unneeded by me. During the 3.0 work it was not clear that serialization could be removed, so I added the newer extensive unit tests including ensuring back compat. Removing it along with all the tests is fine by me.
…________________________________
From: Jan Friedrich ***@***.***>
Sent: Thursday, September 5, 2024 3:29 PM
To: apache/logging-log4net ***@***.***>
Cc: Erik Mavrinac ***@***.***>; Mention ***@***.***>
Subject: Re: [apache/logging-log4net] Remove obsolete properties, methods, and classes for 3.0 (PR #138)
@erikmav<https://github.com/erikmav> because of https://learn.microsoft.com/en-us/dotnet/standard/serialization/binaryformatter-security-guide we think about removing ISerializable and [Serializable] (at least for netstandard).
What do you think?
Where are you using this serialization for log4net objects?
—
Reply to this email directly, view it on GitHub<#138 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHYCQQIPR2XEAPCGCLDYDLZVDLLLAVCNFSM6AAAAABFNMA7OKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMZSG4ZTSNJUGE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
@erikmav thanks for your feedback. |
Hello @erikmav! Log4net crew is actively looking for user feedback and, new members. 😉 @FreeAndNil and I would really appreciate it if we can have a video call with you at your convenience. If that sounds like something you want to participate, would you mind reaching out to me with an email, please? |
Add BinaryFormattter serialize-deserialze testing across versions, and correct serialization property bag names broken by modernization (#124).
Commented out obsolete tag for FixFlags.Mdc as the obsolete tags in MDC.cs are commented out.