Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct example property syntax under ScriptPatternSelector #3092

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

martin-dorey-hv
Copy link
Contributor

Fixes #3078

Attempting to do as requested in #3078 (comment) for @ppkarwasz.

Checklist

Just excuses here, I'm afraid:

Base your changes on 2.x branch if you are targeting Log4j 2; use main otherwise

I don't know what I'm doing wrt branches, here or otherwise, I'm afraid.

./mvnw verify succeeds (if it fails due to code formatting issues reported by Spotless, simply run ./mvnw spotless:apply and retry)

Java 17 would be tricky.

Non-trivial changes contain an entry file in the src/changelog/.2.x.x directory

I'm hoping it's regarded as trivial.

Tests for the changes are provided

Yeah, I didn't do that, but apparently the examples aren't tested, so that's not a regression.

Commits are signed (optional, but highly recommended)

I don't have that set up.

Copy link

Job Requested goals Build Tool Version Build Outcome Build Scan®
build-macos-latest clean install 3.9.8 Build Scan PUBLISHED
build-ubuntu-latest clean install 3.9.8 Build Scan PUBLISHED
build-windows-latest clean install 3.9.8 Build Scan PUBLISHED
Generated by gradle/develocity-actions

Copy link
Contributor

@ppkarwasz ppkarwasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ppkarwasz ppkarwasz merged commit b1b0143 into apache:2.x Oct 16, 2024
9 checks passed
ppkarwasz pushed a commit that referenced this pull request Oct 16, 2024
@ppkarwasz
Copy link
Contributor

@martin-dorey-hv,

Thanks for your PR, your changes should be already online.

hulkoba pushed a commit to neighbourhoodie/logging-log4j2 that referenced this pull request Oct 21, 2024
vy pushed a commit that referenced this pull request Oct 25, 2024
@ppkarwasz ppkarwasz mentioned this pull request Nov 4, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ScriptPatternSelector properties example throws "No type attribute provided for component patternMatch"
3 participants