include two patch,the one is fix limit overflow default size though set not limit,and another fix hive-plugin return data don't support \t #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaojie19852006
changed the title
peacewong
reviewed
Jul 13, 2021
| @@ -0,0 +1,53 @@ | |||
| package com.webank.wedatasphere.linkis.engineplugin.hive.serde; | |||
| if (limitNum > defaultLimit) throw new IllegalArgumentException("We at most allowed to limit " + defaultLimit + ", but your SQL has been over the max rows.") | ||
| } | ||
| !hasLimit | ||
| code.matches("limit\\s+\\d+\\s*;?") |
There was a problem hiding this comment.
It is recommended to delete this code block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
1、commit id 3d86d31(fix limit overflow defaultsize)
issue:当SQL指定limit 大于5000时任务执行失败（#842：https://github.com/WeBankFinTech/Linkis/issues/842）
limit num over default size(wds.linkis.engine.default.limit=5000),though sql include ide.engine.no.limit.allow set no limit
for example:
select * from test limit 10000 --set ide.engine.no.limit.allow=true;
throw error for more than 5000
Brief change log
Verifying this change
delete the function isSelectCmdNoLimit redundancy check
2、commit id 29693a9 and 7b43cf8(fix hive plugin return data incluing \t)
issue:#855
when use hive plugin to query,the return data don't support including \t
add:.../serde/CustomerDelimitedJSONSerDe.java
add:.../hive/serde/LazySimpleSerDe2.java
change: .../hive/conf/HiveEngineConfiguration.scala
change:.../hive/creation/HiveEngineConnFactory.scala
change:.../executor/HiveEngineConnExecutor.scala