-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUES-1276]Upgrade some components of npm that the linkis console depends on #4210
[ISSUES-1276]Upgrade some components of npm that the linkis console depends on #4210
Conversation
9535f1f
to
be0d822
Compare
My PR depends on upgradation of CI/CD from node14.21.2 to node16+. Node16+ now is commonly used so could we please upgrade CI/CD node version? |
Build Frontend failed |
It should be necessary to adjust the action file of the Master branch first::https://github.com/apache/linkis/blob/master/.github/workflows/build-frontend.yml |
Thanks for your remind! I have ajusted build-frontend.yml from node14 to node16. |
1 similar comment
Thanks for your remind! I have ajusted build-frontend.yml from node14 to node16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still a lot to change to fix the Unexpected console statement, Such as Check failure on line 445 in linkis - web/SRC/apps/linkis/module/ECM/index.vue
41a12ce
to
fd57280
Compare
I have missed some places. Thanks for your remind. @det101 |
Upgrade some components of npm that the linkis console depends on
What is the purpose of the change
Upgrade some components of npm that the linkis console depends on.
After fixing:
By the way
1: if developers encounter node-sass related problem when running npm install. It is likely to be the node version incompatibility. You can ajust node-sass version according to the following pic:
2: Please make sure java/scala/js pass the check rule. My last commit is because dev-1.3.2's DsmReceiver.scala has not been formatted properly and I have to regularize again.
@casionone @peacewong
Can we upgrade FrontEnd CI/CD environment to nodeJS 16+?
Some npm packages upgradation depends on higher version nodejs.
My PR depends on upgradation of CI/CD from node14.21.2 to node16+.
Related issues/PRs
Related issues: #1275
Related issues: #1276
Brief change log
Checklist