Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUES-1276]Upgrade some components of npm that the linkis console depends on #4210

Merged
merged 4 commits into from
Feb 15, 2023

Conversation

QuantumXiecao
Copy link
Contributor

@QuantumXiecao QuantumXiecao commented Feb 13, 2023

Upgrade some components of npm that the linkis console depends on

What is the purpose of the change

Upgrade some components of npm that the linkis console depends on.

After fixing:
image
By the way
1: if developers encounter node-sass related problem when running npm install. It is likely to be the node version incompatibility. You can ajust node-sass version according to the following pic:
image
2: Please make sure java/scala/js pass the check rule. My last commit is because dev-1.3.2's DsmReceiver.scala has not been formatted properly and I have to regularize again.

@casionone @peacewong
Can we upgrade FrontEnd CI/CD environment to nodeJS 16+?
Some npm packages upgradation depends on higher version nodejs.
My PR depends on upgradation of CI/CD from node14.21.2 to node16+.

Related issues/PRs

Related issues: #1275
Related issues: #1276

Brief change log

  • Upgrade some components of npm that the linkis console depends on.
  • Reformat code by eslint(Including console related problems).

Checklist

  • I have read the Contributing Guidelines on pull requests.
  • I have explained the need for this PR and the problem it solves
  • I have explained the changes or the new features added to this PR
  • I have added tests corresponding to this change
  • I have updated the documentation to reflect this change
  • I have verified that this change is backward compatible (If not, please discuss on the Linkis mailing list first)
  • If this is a code change: I have written unit tests to fully verify the new behavior.

@QuantumXiecao QuantumXiecao force-pushed the dev-1.3.2-frontend-npmfix branch from 9535f1f to be0d822 Compare February 13, 2023 10:31
@QuantumXiecao
Copy link
Contributor Author

My PR depends on upgradation of CI/CD from node14.21.2 to node16+. Node16+ now is commonly used so could we please upgrade CI/CD node version?

@casionone
Copy link
Contributor

Build Frontend failed
need to update build action base on node 16?

@peacewong
Copy link
Contributor

It should be necessary to adjust the action file of the Master branch first::https://github.com/apache/linkis/blob/master/.github/workflows/build-frontend.yml

@QuantumXiecao
Copy link
Contributor Author

Thanks for your remind! I have ajusted build-frontend.yml from node14 to node16.

1 similar comment
@QuantumXiecao
Copy link
Contributor Author

Thanks for your remind! I have ajusted build-frontend.yml from node14 to node16.

Copy link
Contributor

@det101 det101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still a lot to change to fix the Unexpected console statement, Such as Check failure on line 445 in linkis - web/SRC/apps/linkis/module/ECM/index.vue

@QuantumXiecao QuantumXiecao force-pushed the dev-1.3.2-frontend-npmfix branch from 41a12ce to fd57280 Compare February 14, 2023 02:22
@QuantumXiecao
Copy link
Contributor Author

I have missed some places. Thanks for your remind. @det101

@peacewong peacewong merged commit b47364d into apache:dev-1.3.2 Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants