Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linkis-module]module errorcode optimization and documentation #3550

Conversation

binbinCheng
Copy link
Contributor

[linkis-module]module errorcode optimization and documentation
Related issues: #3424

@codecov
Copy link

codecov bot commented Sep 28, 2022

Codecov Report

Merging #3550 (88ae223) into dev-1.3.1-errorcode (8cc7422) will decrease coverage by 0.51%.
The diff coverage is 0.00%.

❗ Current head 88ae223 differs from pull request most recent head eda1ee4. Consider uploading reports for the commit eda1ee4 to get more accurate results

@@                    Coverage Diff                    @@
##             dev-1.3.1-errorcode    #3550      +/-   ##
=========================================================
- Coverage                  14.29%   13.77%   -0.52%     
+ Complexity                  1523     1307     -216     
=========================================================
  Files                       1032      876     -156     
  Lines                      38197    33820    -4377     
  Branches                    5375     4914     -461     
=========================================================
- Hits                        5461     4660     -801     
+ Misses                     32004    28506    -3498     
+ Partials                     732      654      -78     
Impacted Files Coverage Δ
...main/scala/org/apache/linkis/rpc/RPCMapCache.scala 0.00% <0.00%> (ø)
...pache/linkis/cs/server/conf/ContextServerConf.java 0.00% <0.00%> (-90.91%) ⬇️
...he/linkis/cs/persistence/conf/PersistenceConf.java 0.00% <0.00%> (-88.89%) ⬇️
...che/linkis/jobhistory/transitional/TaskStatus.java 0.00% <0.00%> (-75.00%) ⬇️
...s/cs/errorcode/LinkisCsServerErrorCodeSummary.java 0.00% <0.00%> (-58.83%) ⬇️
...tory/service/impl/JobHistoryQueryServiceImpl.scala 3.49% <0.00%> (-44.11%) ⬇️
...adata/query/server/receiver/BaseMetaReceiver.scala 9.52% <0.00%> (-28.58%) ⬇️
...inkis/jobhistory/conversions/TaskConversions.scala 7.53% <0.00%> (-13.07%) ⬇️
...e/linkis/cs/persistence/util/PersistenceUtils.java 0.00% <0.00%> (-7.05%) ⬇️
...org/apache/linkis/jobhistory/util/QueryUtils.scala 27.05% <0.00%> (-5.89%) ⬇️
... and 181 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -209,7 +205,7 @@ object SSOUtils extends Logging {
) > sessionTimeout
) {
userTicketIdToLastAccessTime.remove(userTicketId)
throw new LoginExpireException("Login has expired, please log in again!(登录已过期,请重新登录!)")
throw new LoginExpireException(NOT_LOGGED.getErrorDesc)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Login has expired, please log in again!(登录已过期,请重新登录!"
not
"You are not logged in, please login first!(您尚未登录,请先登录!)"

@casionone casionone changed the base branch from dev-1.3.1 to dev-1.3.1-errorcode October 16, 2022 05:45
@casionone casionone merged commit 46259eb into apache:dev-1.3.1-errorcode Oct 18, 2022
@binbinCheng binbinCheng deleted the dev-1.3.1-linkis-module-errorcode branch October 18, 2022 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants