Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support startup scripts compatible with multiple service names #3500

Merged
merged 2 commits into from
Sep 23, 2022

Conversation

huangxiaopingRD
Copy link
Contributor

Related issues: #3499

Test case:
image

@huangxiaopingRD
Copy link
Contributor Author

@casionone Can you help with a review? thanks

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #3500 (3efdaf8) into dev-1.3.1 (6cb28d6) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.3.1    #3500      +/-   ##
===============================================
- Coverage        14.27%   14.25%   -0.02%     
+ Complexity        1256     1255       -1     
===============================================
  Files              820      820              
  Lines            31613    31613              
  Branches          4676     4676              
===============================================
- Hits              4512     4508       -4     
- Misses           26451    26453       +2     
- Partials           650      652       +2     
Impacted Files Coverage Δ
...a/org/apache/linkis/scheduler/queue/Consumer.scala 85.71% <0.00%> (-14.29%) ⬇️
...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala 36.79% <0.00%> (-1.89%) ⬇️
...lugin/spark/executor/SparkEngineConnExecutor.scala 29.32% <0.00%> (-0.76%) ⬇️
...n/engineconn/EngineConnExecutorErrorException.java
...eption/engineconn/EngineConnExecutorErrorCode.java
...n/engineconn/EngineConnExecutorErrorException.java 0.00% <0.00%> (ø)
...eption/engineconn/EngineConnExecutorErrorCode.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@casionone
Copy link
Contributor

Other service names can also be supported together

linkis-cg-engineconnmanager
linkis-cg-engineplugin
linkis-cg-entrance
linkis-cg-linkismanager
linkis-mg-gateway
linkis-ps-publicservice

@huangxiaopingRD
Copy link
Contributor Author

Other service names can also be supported together

linkis-cg-engineconnmanager
linkis-cg-engineplugin
linkis-cg-entrance
linkis-cg-linkismanager
linkis-mg-gateway
linkis-ps-publicservice

done

@huangxiaopingRD huangxiaopingRD changed the title Supports startup script parameters compatible with multiple names of publicservice Support startup scripts compatible with multiple service names Sep 22, 2022
Copy link
Contributor

@casionone casionone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@casionone casionone merged commit 46afeb8 into apache:dev-1.3.1 Sep 23, 2022
@huangxiaopingRD huangxiaopingRD deleted the dev-1.3.1-publicservice branch September 23, 2022 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants