Opt format code #2458
Opt format code #2458
Conversation
Codecov Report
@@ Coverage Diff @@
## dev-1.2.0 #2458 +/- ##
===============================================
- Coverage 16.65% 16.64% -0.02%
+ Complexity 1106 1105 -1
===============================================
Files 636 636
Lines 19529 19529
Branches 2770 2770
===============================================
- Hits 3252 3250 -2
- Misses 15841 15843 +2
Partials 436 436
Continue to review full report at Codecov.
|
| @@ -36,7 +36,6 @@ | |||
| <groupId>org.apache.linkis</groupId> | |||
| <artifactId>linkis-common</artifactId> | |||
| <version>${linkis.version}</version> | |||
| <scope>provided</scope> | |||
There was a problem hiding this comment.
the common and storage are all the shared module, the provided scope is not need. and the storage miss the commons-lang3 jar, which is import by runtime scope by other jars, so change the scope of linkis-common's scope to fix the dependency miss.
| @@ -138,8 +138,6 @@ object EngineConnMonitor extends Logging { | |||
| endJobByEngineInstance(status._1) | |||
| } | |||
| } | |||
| case o: Any => | |||
| logger.error(s"Status of engine ${status._1.toString} is ${status._2}") | |||
There was a problem hiding this comment.
should update to case _: log
There was a problem hiding this comment.
the NodeExistStatus is a enum, all the above case coverd all branch. And the case o: Any block is't reachable
What is the purpose of the change
refactor some code
ref to #1475
Brief change log
(for example:)
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
Documentation