Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LINKIS #1632] Add linkis-engineplugin-elasticsearch module #2308

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

wForget
Copy link
Member

@wForget wForget commented Jun 19, 2022

What is the purpose of the change

Enhance ElasticSearchEngine, adatps to Linkis1.X architecture.
close #1632

Brief change log

  • Implement the linkis-engineplugin-elasticsearch module according to the engine development specification.

Verifying this change

  • Using UJESClient, submit a elasticsearch json query task to verify it.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes)
  • Anything that affects deployment: (no)
  • The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (not documented)

@wForget wForget self-assigned this Jun 19, 2022
@wForget wForget requested a review from peacewong June 19, 2022 09:21
@codecov
Copy link

codecov bot commented Jun 19, 2022

Codecov Report

Merging #2308 (6cc99ec) into dev-1.2.0 (210c932) will increase coverage by 1.87%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             dev-1.2.0    #2308      +/-   ##
===============================================
+ Coverage        20.57%   22.44%   +1.87%     
- Complexity        1056     1060       +4     
===============================================
  Files              455      455              
  Lines            13920    13963      +43     
  Branches          2192     2200       +8     
===============================================
+ Hits              2864     3134     +270     
+ Misses           10667    10391     -276     
- Partials           389      438      +49     
Impacted Files Coverage Δ
...s/scheduler/queue/fifoqueue/FIFOUserConsumer.scala 33.33% <0.00%> (-1.12%) ⬇️
...g/apache/linkis/common/variable/VariableType.scala 17.80% <0.00%> (+17.80%) ⬆️
...apache/linkis/common/variable/CustomDateType.scala 57.62% <0.00%> (+57.62%) ⬆️
...org/apache/linkis/common/utils/VariableUtils.scala 60.11% <0.00%> (+60.11%) ⬆️
.../apache/linkis/common/variable/DateTypeUtils.scala 74.78% <0.00%> (+74.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 210c932...6cc99ec. Read the comment docs.

@wForget wForget requested review from casionone and peacewong June 22, 2022 14:35
Copy link
Contributor

@peacewong peacewong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peacewong peacewong merged commit 0074b9e into apache:dev-1.2.0 Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants